Subj : Not a test
To   : apam
From : Accession
Date : Sat Jan 20 2024 06:25 am

Hello apam,

On Sun, 21 Jan 2024 00:36:20 +1000, you wrote:

 a> One thing I noticed when I was using some stuff that did something
 a> similar (Crashmail2  when I was working on Magicka) Is who ever wrote it
 a> made some assumptions about how the C library copied strings, which
 a> turned out not to be true anymore.

 a> The specific bug I think (and it was a long time ago) was something
 a> along the lines of

 a> strcpy(subject, &subject[4])

There seems to be a lot of lines in Jamnntpd's code that looks similar to this. My first search for "strcpy" came up with:

strcpy(addr,&originbuf[d+1]);

.... and there's many more. :(

 a> It was to do with stripping the (Re: from the start of messages), it
 a> expected strcpy to copy one character at a time sequentially.

 a> The fix I used was to just:

 a> char *subj_copy = strdup(&subject[4]);

 a> strcpy(subject, subj_copy);

 a> free(subj_copy)

 a> I don't know it it will help you with JamNNTP but, I wouldn't be
 a> suprised if they used some "clever" tricks like that.

You definitely might be on to something there, since Jamnntpd is quite old. The only bummer is that it seems as though that's used just about everywhere, including fromaddr, fromname, toname, replyaddr, and many more variables. I'll see if I can compare the two a bit more and see why Smapinntpd works better in this regard. Thanks for the heads up!

Regards,
Nick

.... "Take my advice, I don't use it anyway."
--- Claws Mail 4.2.0 (GTK 3.24.38; x86_64-w64-mingw32)
 * Origin: _thePharcyde distribution system (Wisconsin) (21:1/200.0)

.