Subj : Re: Latest sources..
To   : Nicholas Boel
From : Vitaliy Aksyonov
Date : Thu Feb 15 2024 06:04 pm

Привет, Nicholas!

15 Feb 24 14:23, ты писал(а) мне:

 VA>> My last commit rollback some change I made previously because it
 VA>> was found to be buggy in some cases. So it could be some other
 VA>> change actually.

 VA>> If you familiar with git, would be nice if you hunt down which
 VA>> commit makes things worse in your setup. You may use git bisect
 VA>> for that.

 VA>> https://git-scm.com/docs/git-bisect

 NB> I'm not very familiar with it, but I was able to figure it out with
 NB> the link you provided. Thank you!

 NB> $ git bisect start
 NB> $ git bisect bad
 NB> $ git bisect good f7be1e97e251ee2be20f63abdcf2a18f93c880b9

 NB> I chose this commit because it was just prior to the 'revert "zero
 NB> conversion" workaround', where things were definitely looking more
 NB> towards 'normal'.

For bisect you better chose wider range. Like a year or so. With bisect you only need ln(N) tries to find broken commit. It could be broken earlier actually.

 NB> $ make BUILD=minimal (this compiled version 20231112 for some reason I
 NB> don't yet understand)

Minimal build disables some stuff like spellchecker. It shall not affect version. That's strange. Also cleaning previous build results may help.

 NB> It was back to normal with this compile.

 NB> $ git bisect good
 NB> $ make BUILD=minimal (this compiled version 20240206)

 NB> It was still good.

 NB> $ git bisect good

 NB> https://pharcyde.org/git-bisect-result.png

 NB> It seems as though I'm back to the way it was in version GoldED+/LNX
 NB> 1.1.5-b20240206. Here is an example:

 NB> https://pharcyde.org/golded-20240206.png

 NB> $ git bisect reset (to go back to the master branch 20240209)
 NB> $ make BUILD=minimal

 NB> https://pharcyde.org/golded-20240209.png

 NB> Same configuration in golded.conf:

 NB> [ start paste ]

 NB> # Character translation path
 NB> xlatpath /home/axisd/src/golded-plus/cfgs/charset
 NB> include /home/axisd/src/golded-plus/cfgs/config/charsets.cfg

 NB> # UTF-8 Configuration
 NB> #
 NB> xlatcharset     utf-8           utf-8           utf_utf.chs

 NB> xlatimport      cp437
 NB> xlatexport      utf-8
 NB> xlatlocalset    utf-8

 NB> [ end paste ]

You have xlatimport cp437.

Does that message with broken pseudo-graphics have CHRS kludge? If not - is it really in cp437 encoding? Pseudo-graphics characters located in second half of charset table and it's different for different charsets.

Best regards,
Vitaliy Aksyonov.

--- GoldED+/LNX 1.1.5-b20231030
 * Origin: Aurora, Colorado (1:104/117)

.