Subj : dark mode for webv4
To   : GitLab note in main/sbbs
From : Michael Long
Date : Tue Jan 05 2021 10:36 am

https://gitlab.synchro.net/main/sbbs/-/merge_requests/68#note_1286

> Please avoid bundling whitespace changes in with unrelated requests. I can't tell at a glance if there are > any functional changes to home.xjs or games.xjs.

That is not whitespace change, that is putting those blocks into event handlers to delay the load of ftelnet until the html is unhidden. (And it is hidden until JS loads to avoid it flashing white each page load)

> Is checkbox.css and all of the related "checkbox" stuff just there to facilitate an "enable dark mode" >checkbox? (Just curious.)

Correct. I may have been able to do a bit better with bootstrap 4 but since its bootstrap 3 I just went with this

> An option should be added to modopts.ini->\[web\] so that the sysop can decide whether they want to  offer dark mode. This option should control whether the checkbox is shown and whether checkbox.css (or any other unnecessary-if-disabled) stuff is sent. (If you did this, great - I may have missed it.)

Ok will add this

> I see some inline styling added to index.xjs:
> `.hidden { display:none; }`
> I'd rather this kind of thing be in style.css unless it really needs to be inline (eg. to override something). Just an organizational consideration.

yes in this case I inlined it because I was it executed immediately and not wait for style.css to load. This helps avoid the screen flashing white before css is processed, when you are in dark mode

> I have no problem with their being a default "dark mode"; the sysop can make the light and dark modes look however they want via custom.css. (We don't need to offer "hot pink mode" or anything else; that's up to the sysop to define - but light/dark makes sense.)

I briefly thought about theme support, but was more work than I wanted to do and really isn't something I see on the web much anyway except maybe office 365 and vbulletin

.