Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Mon Feb 22 2021 01:58 pm

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
65 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 320538:  Error handling issues  (NEGATIVE_RETURNS)
/sbbsecho.c: 3240 in getfmsg()


________________________________________________________________________________________________________
*** CID 320538:  Error handling issues  (NEGATIVE_RETURNS)
/sbbsecho.c: 3240 in getfmsg()
3234     	if((fbuf = malloc(length+1)) == NULL) {
3235     		lprintf(LOG_ERR,"ERROR line %d allocating %lu bytes of memory",__LINE__,length+1);
3236     		bail(1);
3237     		return(NULL);
3238     	}
3239
>>>     CID 320538:  Error handling issues  (NEGATIVE_RETURNS)
>>>     "start" is passed to a parameter that cannot be negative.
3240     	(void)fseeko(stream,start,SEEK_SET);
3241     	for(l=0;l<length;l++)
3242     		fbuf[l]=(uchar)fgetc(stream);
3243     	if(ch==0)
3244     		(void)fgetc(stream);		/* Read NULL */
3245


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3Der7L_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrBQ53SIRFot2xRYrhIb3eC4tGmFai6Veu26y21-2FI1cyxbxrGgffvh5-2FDuSx5bpT7Z9VM5zkLHWKKaZmebxX9RJmd7FqCC6YAxixNAWbnXvqkNggB8vBu-2BSBeotQMnU-2Bu01fhkm151yNMMLzlAR1E3yvMKjcwyWAxKvQU4oA8hCpOp3c9-2BVt6Y3ry98V3M2efIU-3D



.