Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Thu Feb 24 2022 01:48 pm

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
24 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 349724:  Error handling issues  (NEGATIVE_RETURNS)
/userdat.c: 1464 in readsmsg()


________________________________________________________________________________________________________
*** CID 349724:  Error handling issues  (NEGATIVE_RETURNS)
/userdat.c: 1464 in readsmsg()
1458     		return(NULL);
1459     	length=(long)filelength(file);
1460     	if((buf=(char *)malloc(length+1))==NULL) {
1461     		close(file);
1462     		return(NULL);
1463     	}
>>>     CID 349724:  Error handling issues  (NEGATIVE_RETURNS)
>>>     "length" is passed to a parameter that cannot be negative. [Note: The source code implementation of the function has been overridden by a builtin model.]
1464     	if(read(file,buf,length)!=length) {
1465     		close(file);
1466     		free(buf);
1467     		return(NULL);
1468     	}
1469     	chsize(file,0L);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DZ7BT_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDucsQet7CN5MeeBVgzW5eMSbGJc98qxHaPqqpHg3TIaoOBdI0-2Fh66lpiqU3c7CTkLjsmoHkqGMIjv4PN-2BcxufHSQLgsk2bl9kf5PCWevTsdhIK1WzMoJrUv6QopHr8CuiCaFyxCZli-2BhnO6LtGVDH4Z9lxeUXAnTW6djeJddagaQ-3D-3D



.