Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Tue Feb 21 2023 01:36 pm

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 436563:  High impact quality  (Y2K38_SAFETY)
/tmp/sbbs-Feb-21-2023/src/smblib/smblib.c: 2033 in smb_create()


________________________________________________________________________________________________________
*** CID 436563:  High impact quality  (Y2K38_SAFETY)
/tmp/sbbs-Feb-21-2023/src/smblib/smblib.c: 2033 in smb_create()
2027     	rewind(smb->sid_fp);
2028     	if(chsize(fileno(smb->sid_fp),0L) != 0)
2029     		return SMB_ERR_TRUNCATE;
2030
2031     	SAFEPRINTF(str,"%s.ini",smb->file);
2032     	if((fp = fopen(str, "w")) != NULL) {
>>>     CID 436563:  High impact quality  (Y2K38_SAFETY)
>>>     A "time_t" value is stored in an integer with too few bits to accommodate it.  The expression "time(NULL)" is cast to "int".
2033     		fprintf(fp, "Created = 0x%x\n", (int)time(NULL));
2034     		fclose(fp);
2035     	}
2036     	SAFEPRINTF(str,"%s.sda",smb->file);
2037     	(void)remove(str);						/* if it exists, delete it */
2038     	SAFEPRINTF(str,"%s.sha",smb->file);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3D6NZ4_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrB-2BSws-2BCbxlcVNPlCMlu3BJhlBm9ihxGUC5HVYM0IVOs04Kz9bZ0eoogx9vF3V4RK7H-2FAqguVEOaGqUDhn-2BkizHNIhtSAreEeh-2FFRCp4Cd-2BnjQP8DEfNeZ9f9ZPjHBz4mF3SSPlmrjqNIqJn1YzLbAFkkez3JgMfD0h7jKBCjInFw-3D-3D



.