Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Fri Jul 21 2023 12:39 pm

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 462777:  Error handling issues  (CHECKED_RETURN)
/sbbsecho.c: 1796 in alter_areas()


________________________________________________________________________________________________________
*** CID 462777:  Error handling issues  (CHECKED_RETURN)
/sbbsecho.c: 1796 in alter_areas()
1790     			chmod(outpath, st.st_mode);
1791     		if(cfg.areafile_backups == 0 || !backup(cfg.areafile, cfg.areafile_backups, /* ren: */TRUE))
1792     			delfile(cfg.areafile, __LINE__);					/* Delete AREAS.BBS */
1793     		if(rename(outpath,cfg.areafile))		   /* Rename new AREAS.BBS file */
1794     			lprintf(LOG_ERR,"ERROR line %d renaming %s to %s",__LINE__,outpath,cfg.areafile);
1795     	}
>>>     CID 462777:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "remove(outpath)" without checking return value. This library function may fail and return an error code.
1796     	remove(outpath); // expected to fail (file does not exist) much of the time
1797     }
1798
1799     bool add_sub_to_arealist(sub_t* sub, fidoaddr_t uplink)
1800     {
1801     	FILE* fp = NULL;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3D9Jsa_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrBb4277PBgEvmZlC-2F75f6Wn0OW7OlFk2c1B-2BHtshOYvFkBSQP9EqEdk2ezaBaEw-2BucLGwfFouHIfPe-2Fyudqe7-2BvtImpG7nG3GNHNovDhmEdP7PSdTfD3wACCQeKNpizxWyAzNP4xAGsoa5IGtqS3OShzACd7MFIxkk2Y7iSTOvrLw-3D-3D



.