Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Thu Nov 23 2023 01:39 pm

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
11 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 469167:    (SLEEP)


________________________________________________________________________________________________________
*** CID 469167:    (SLEEP)
/main.cpp: 2494 in output_thread(void *)()
2488     				 */
2489     				size_t sendbytes = buftop-bufbot;
2490     				if (sendbytes > 0x2000)
2491     					sendbytes = 0x2000;
2492     				if(cryptStatusError((err=cryptPushData(sbbs->ssh_session, (char*)buf+bufbot, buftop-bufbot, &i)))) {
2493     					/* Handle the SSH error here... */
>>>     CID 469167:    (SLEEP)
>>>     Call to "lprintf" might sleep while holding lock "sbbs->ssh_mutex".
2494     					GCESSTR(err, node, sbbs->ssh_session, "pushing data");
2495     					ssh_errors++;
2496     					sbbs->online=FALSE;
2497     					i=buftop-bufbot;	// Pretend we sent it all
2498     				}
2499     				else {
/main.cpp: 2479 in output_thread(void *)()
2473     			}
2474     			if(!sbbs->ssh_mode) {
2475     				pthread_mutex_unlock(&sbbs->ssh_mutex);
2476     				continue;
2477     			}
2478     			if (cryptStatusError((err=cryptSetAttribute(sbbs->ssh_session, CRYPT_SESSINFO_SSH_CHANNEL, sbbs->session_channel)))) {
>>>     CID 469167:    (SLEEP)
>>>     Call to "lprintf" might sleep while holding lock "sbbs->ssh_mutex".
2479     				GCESSTR(err, node, sbbs->ssh_session, "setting channel");
2480     				ssh_errors++;
2481     				sbbs->online=FALSE;
2482     				i=buftop-bufbot;	// Pretend we sent it all
2483     			}
2484     			else {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4E6fW2ok94RcmG1J20ETIf4-3D5OUN_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrAWre6lEuRZshFB9v23oRHfb6cJViSmU6jeWo6H6qjr2TD-2FKFU3E7Wk43r5o6gE3xpEUu2LCxXDEO7eIcPPMxFL1Nq6AhOVschJGcr-2Bj9V3IL2-2BV5MIEfM79IRScL2ukizExtyrX8BpZAnSaCd3CJdrnZtJg68NUadTHcpkaQqA0A-3D-3D



.