Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Tue Jan 09 2024 01:51 pm

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 477525:  Error handling issues  (CHECKED_RETURN)
/ssl.c: 413 in get_ssl_cert()


________________________________________________________________________________________________________
*** CID 477525:  Error handling issues  (CHECKED_RETURN)
/ssl.c: 413 in get_ssl_cert()
407     	CRYPT_CERTIFICATE	ssl_cert;
408     	char			sysop_email[sizeof(cfg->sys_inetaddr)+6];
409     	struct cert_list *cert_entry;
410
411     	if(!do_cryptInit(lprintf))
412     		return -1;
>>>     CID 477525:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "ssl_sync" without checking return value (as is done elsewhere 6 out of 7 times).
413     	ssl_sync(cfg, lprintf);
414     	lock_ssl_cert_write();
415     	cert_entry = malloc(sizeof(*cert_entry));
416     	if(cert_entry == NULL) {
417     		unlock_ssl_cert_write(lprintf);
418     		free(cert_entry);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4E6fW2ok94RcmG1J20ETIf4-3DG04V_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDEpEnmlDe-2FjbKZ4LOKbSyZqFRJl-2FW97DzLqL9YhzmfB5NVnMDaFqAVAu8sqMXAtM7gluOaLuz78sK9hLjatBB8CSJ6nN9iJHgKoglAvkWzF0D2D3-2FP2KvQ4r0FVsLXVQDobxZi1VHS1fHv1o1JN4QuvSLew5iAWvpjb3EkIuqiHp61IxzA0v1Q4zB-2F2vdQH-2Fs-3D



.