https://bugzilla.mozilla.org/show_bug.cgi?id=259640
Bugzilla
Quick Search
[ ]
* Browse
* Advanced Search
* Reports
*
* Documentation
* New Account
* Log In
Sign in with GitHub or
[ ] [ ]
[password ] [*] Remember [Log in]
* Forgot Password
[ ] [Reset Password]
[moz]
* Mozilla Home
*
* Privacy
* Cookies
* Legal
Please enable JavaScript in your browser to use all the features on
this site.
Copy Summary
[ ]
View V
* Reset Sections
* Expand All Sections
* Collapse All Sections
*
* History
*
* JSON
* XML
Closed Bug 259640 Opened 17 years ago Closed 21 days ago
Find Toolbar's highlight mode should show matches next to or on top
of scrollbar
Summary:
Find Toolbar's highlight mode should show matches next to or on top
of scrollbar
Categories
(Toolkit :: Find Toolbar, enhancement, P3)
Product:
Toolkit V
Toolkit
The Mozilla Toolkit is a set of APIs, built on top of Gecko, which
provide advanced services to XUL applications. These services include
Profile Management, Chrome Registration, Browsing History, Extension
and Theme Management, Application Update Service, and Safe Mode. (
More info)
See Open Bugs in This Product
File New Bug in This Product
Watch This Product
Component:
Find Toolbar V
Toolkit :: Find Toolbar
Find as you Type/Find Toolbar
See Open Bugs in This Component
Recently Fixed Bugs in This Component
File New Bug in This Component
Watch This Component
Version:
Trunk
Platform:
All
All
Type:
enhancement
Priority:
P3
Severity:
normal
Points:
---
Tracking
()
Status:
RESOLVED FIXED
Status:
RESOLVED
FIXED
Mark as Assigned
Milestone:
87 Branch
Iteration:
---
Project Flags:
a11y-review [---]
Root Cause [---]
Webcompat Priority [---]
user-doc-firefox [---]
Fission Milestone [---]
Tracking Flags:
Tracking Status
relnote-firefox --- ?
firefox87 --- fixed
Tracking Status
relnote-firefox [?]
thunderbird_esr78 [---] [---]
firefox-esr78 [---] [---]
firefox86 [---] [---]
firefox87 [---] [fixed]
firefox88 [---] [---]
People
(Reporter: keith, Assigned: enndeakin, NeedInfo)
Assignee:
# enndeakin
Assignee:
[ ] Reset Assignee to default
Mentors:
---
QA Contact:
[ ] Reset QA Contact to default
Reporter:
# keith
Triage Owner:
# mikedeboer
NeedInfo From:
enndeakin
16 days ago
mikedeboer
16 days ago
NeedInfo:
Update
CC:
88 people
References
(Depends on 2 open bugs, Blocks 5 open bugs)
Depends on:
1693784, 1694027, 1690783, 1690791, 1691978
Blocks:
565552, 1271782
422383, 1690128, 1690129
Dependency tree / graph
Regressions:
---
Regressed by:
---
Duplicates:
556020, 1112033, 1352786, 1427599
303964, 477416, 516147, 583993, 590098, 1251607, 1335439, 1543382,
1558487, 1628738
URL:
See Also:
---
Details
(Keywords: parity-chrome, Whiteboard: p=13)
Alias:
---
Keywords:
parity-chrome
Whiteboard:
p=13
QA Whiteboard:
---
Has Regression Range:
---
Has STR:
---
Votes:
57
Bug Flags:
MarcoM firefox-backlog +
MarcoM firefox-backlog [+]
behind-pref [ ]
sec-bounty [ ]
sec-bounty-hof []
in-qa-testsuite [ ] [ ]
in-testsuite [ ]
qe-verify []
Crash Data
Signature:
Security
(public)
This bug is publicly visible.
User Story
Attachments
(8 files)
#Screenshot from IntelliJ IDEA showing matches
along the scrollbar
17 years ago Details
Keith Lea
11.52 KB, image/png
Bug 259640 - Hacky proof of concept to have Find
Toolbar's highlight mode should show matches on mikedeboer
top of scrollbar. : Details
5 years ago feedback+
Jared Wein [:jaws] (please needinfo? me)
58 bytes, text/x-review-board-request
Bug 259640, add chrome only method to add
scrollbar tick marks to a window, r=smaug,tnikkel Details
2 months ago |
Neil Deakin Review
48 bytes, text/x-phabricator-request
Bug 259640, paint tick marks on vertical sliders
for the root scroll frame of the document if any Details
have been assigned to the window, r=tnikkel |
2 months ago Review
Neil Deakin
48 bytes, text/x-phabricator-request
Bug 259640, update the scroll marks when a find in
page highlight in completed, using the positions
of the highlights as the marker points, r= Details
mikedeboer |
2 months ago Review
Neil Deakin
48 bytes, text/x-phabricator-request
Bug 259640, add some reftests that verify that
scrollbar marks are drawn, r=tnikkel Details
2 months ago |
Neil Deakin Review
48 bytes, text/x-phabricator-request
Bug 259640, adjust the height of the find marks on
scrollbars based on dpi, r=tnikkel Details
1 month ago |
Neil Deakin Review
48 bytes, text/x-phabricator-request
Bug 259640, fix highlightAll reference, r=
mikedeboer Details
20 days ago |
Neil Deakin Review
48 bytes, text/x-phabricator-request
Bottom |
Tags V
* Reset
Timeline V
* Reset
*
* Collapse All
* Expand All
* Comments Only
Keith Lea
Reporter
[045] Description
*
17 years ago
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10
Some text editors will show matches of a search string next to the scrollbar, so
you can see quickly how many matches there are, and where they are located on
the page. I'd like Firefox's find toolbar to do this as well.
I've attached a screenshot of how IntelliJ IDEA does this.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Keith Lea
Reporter
[045] Comment 1
*
17 years ago
Attached image Screenshot from IntelliJ IDEA showing matches along
the scrollbar -- Details
Keith Lea
Reporter
[045] Comment 2
*
17 years ago
Comment on attachment 159011 [details]
Screenshot from IntelliJ IDEA showing matches along the scrollbar
The green lines next to the scrollbar show where the matches are on the page.
Nickolay_Ponomarev
Updated
[ea3]
*
17 years ago
Status: UNCONFIRMED - NEW
Ever confirmed: true
OS: Windows XP - All
Hardware: PC - All
Jesse Ruderman
Comment 3
[d2d]
*
16 years ago
*** Bug 303964 has been marked as a duplicate of this bug. ***
Ng Ming Hong
Comment 4
[a78]
*
16 years ago
But when a page is not long enough, there are no scrollbar...
Jesse Ruderman
Comment 5
[d2d]
*
16 years ago
On non-scrolling pages, you don't need this feature, because you can spot the yellow areas without scrolling.
Peter Kasting
Comment 6
[6c4]
*
15 years ago
I'm going to take this bug so maybe someday I can do it. Way too hard for now, but it would be very nice to have.
Marking depends on 77790 as the right solution here may involve being able to style the scrollbar.
Assignee: firefox - pkasting
Depends on: scrollbar-colors
Phil Ringnalda (:philor)
Updated
[2b6]
*
15 years ago
QA Contact: fast.find
Peter Kasting
Comment 7
[6c4]
*
14 years ago
Not going to be getting to this one.
Peter Kasting
Comment 8
[6c4]
*
14 years ago
Oops, meant to unassign :P
Assignee: pkasting - nobody
:ehsan akhgari
Updated
[51f]
*
13 years ago
Version: unspecified - Trunk
Nobody; OK to take it and work on it
Updated
[eaa]
*
13 years ago
Product: Firefox - Toolkit
Graeme McCutcheon [:graememcc]
Updated
[948]
*
12 years ago
Duplicate of this bug: 477416
Graeme McCutcheon [:graememcc]
Updated
[948]
*
12 years ago
Duplicate of this bug: 516147
:Gavin Sharp [email: gavin@gavinsharp.com]
Updated
[08d]
*
11 years ago
Duplicate of this bug: 556020
u88484
Updated
[b7e]
*
11 years ago
Whiteboard: [Parity-Chrome]
Jo Hermans
Updated
[dd4]
*
11 years ago
Duplicate of this bug: 590098
Siddhartha Dugar [:sdrocking]
Comment 13
[82e]
*
10 years ago
https://addons.mozilla.org/en-US/firefox/addon/scrollbar-search-highlighter/
does this in some way.
Wayne Mery (:wsmwk)
Updated
[206]
*
10 years ago
Blocks: 422383
Wayne Mery (:wsmwk)
Updated
[206]
*
10 years ago
Duplicate of this bug: 583993
Wayne Mery (:wsmwk)
Updated
[206]
*
10 years ago
Blocks: 565552
Colby Russell :crussell (no longer Mozilla-ing)
Comment 15
[da0]
*
8 years ago
Bug 384458, comment 4 is relevant.
Colby Russell :crussell (no longer Mozilla-ing)
Updated
[da0]
*
8 years ago
No longer depends on: scrollbar-colors
Luis Miguel [:quicksaver] (not reading bugmail)
Comment 16
[7a1]
*
8 years ago
For anyone concerned, https://addons.mozilla.org/en-US/firefox/addon/findbar-tweak/ does this by placing an overlay over the scrollbar area with the found matches, in a similar way as the current WIP patch at bug 384458 (element inside the browser stack).
To whomever eventually takes this, don't forget frames! Pages with large iframes will likely be just wrong, and frameset based pages won't actually have a "main" scrollbar to use for this. The latest 1.4-beta of FBT tries to address this by placing similar boxes into the content that overlay the frame elements where their scrollbars should be.
Marco Mucci [:MarcoM]
Updated
[77b]
*
7 years ago
Whiteboard: [Parity-Chrome] - [Parity-Chrome] [feature] p=0
Marco Mucci [:MarcoM]
Updated
[77b]
*
7 years ago
Blocks: fxdesktopbacklog
Marco Mucci [:MarcoM]
Updated
[77b]
*
7 years ago
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Whiteboard: [Parity-Chrome] [feature] p=0 - [Parity-Chrome] p=13
Mike de Boer [:mikedeboer]
Updated
[712]
*
6 years ago
Duplicate of this bug: 1112033
Mike de Boer [:mikedeboer]
Updated
[712]
*
5 years ago
Priority: -- - P1
Mike de Boer [:mikedeboer]
Updated
[712]
*
5 years ago
Duplicate of this bug: 1251607
Justin Dolske [:Dolske]
Updated
[109]
*
5 years ago
Blocks: 1271782
Jared Wein [:jaws] (please needinfo? me)
Comment 19
[f4a]
*
5 years ago
(In reply to Luis Miguel [:quicksaver] from comment #16)
> For anyone concerned,
> https://addons.mozilla.org/en-US/firefox/addon/findbar-tweak/ does this by
> placing an overlay over the scrollbar area with the found matches, in a
> similar way as the current WIP patch at bug 384458 (element inside the
> browser stack).
>
> To whomever eventually takes this, don't forget frames! Pages with large
> iframes will likely be just wrong, and frameset based pages won't actually
> have a "main" scrollbar to use for this. The latest 1.4-beta of FBT tries to
> address this by placing similar boxes into the content that overlay the
> frame elements where their scrollbars should be.
Luis, would you consider writing a patch for this? I looked at Chrome Canary and they don't show the matches on their scrollbar if they are inside of an iframe. We could implement the simple approach by only showing matches in the top-level frame on the top-level frame's scrollbar and we would be no worse than what is shipping today in Chrome Canary.
You can use the new FinderHighlighter.jsm module which should make this more straightforward to implement. Mike de Boer can help you with navigating FinderHighlighter.
Flags: needinfo?(quicksaver)
Luis Miguel [:quicksaver] (not reading bugmail)
Comment 20
[7a1]
*
5 years ago
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #19)
> Luis, would you consider writing a patch for this?
I would love to! But realistically speaking I won't be able to even dream about hacking on Firefox code like this any time soon. Likely not before 2017 even... :(
Flags: needinfo?(quicksaver)
Jared Wein [:jaws] (please needinfo? me)
Comment 21
[f4a]
*
5 years ago
mozreview-request
Comment hidden (mozreview-request)
Attached file Bug 259640 - Hacky proof of concept to have Find
Toolbar's highlight mode should show matches on top of scrollbar. --
Details
Review commit: https://reviewboard.mozilla.org/r/80472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80472/
Attachment #8793871 - Flags: review?(mdeboer)
Mike de Boer [:mikedeboer]
Comment 22
[712]
*
5 years ago
mozreview-review
Comment on attachment 8793871 [details]
Bug 259640 - Hacky proof of concept to have Find Toolbar's highlight mode should show matches on top of scrollbar.
https://reviewboard.mozilla.org/r/80472/#review79350
::: toolkit/content/minimal-xul.css:104
(Diff revision 1)
> -scrollbar, scrollbarbutton, scrollcorner, slider, thumb, scale {
> +marker {
> + -moz-binding: url(chrome://global/content/bindings/scrollbar.xml#marker);
> + display: -moz-box !important;
> +}
> +
> +scrollbar, scrollbarbutton, scrollcorner, slider, thumb, marker, scale {
I think the original idea was to have this in alphabetical order... or something :)
::: toolkit/content/widgets/scrollbar.xml:14
(Diff revision 1)
> -
> -
>
> +
> +
> +
Did `bidning` ever work?
::: toolkit/modules/FinderHighlighter.jsm:1048
(Diff revision 1)
> dict.modalHighlightAllMask.setCutoutRectsForElement(kMaskId, allRects);
> + this._setScrollbarMarkers(window, allRects, width, height);
> + },
> +
> + _setScrollbarMarkers(window, rects, width, height) {
> + if (!window || !window.document || !window.document.documentElement) {
Instead of a separate method for this, what do you think about the following ideas?
* Create a helper method that fetches all the scrollbar nodes, like the first bootstrap part here, something like `_getScrollbarMarkerNodes()`
* Integrate with the for-loop in `_repaintHighlightAllMask()` to lose the overhead of another loop
* Lazily create marker nodes and re-use the ones that are already there. After the loop, hide the marker nodes that you didn't need, if any.
* Use `marker.onclick = e => {}` to make sure there's only one event listener that always does what you'd expect
* For the scrolling behavior, use `range.startContainer.scrollIntoView()` to have it work (I think almost) like regular find-in-page navigation
* Percentage-based positioning would be ultra-nice... but the highlights repaint after a window resize anyways, so you get repositioning for 'free'.
* `parseFloat` doesn't know about a second 'base' argument, but I think you don't need that cast anyway.
Mike de Boer [:mikedeboer]
Comment 23
[712]
*
5 years ago
Super cool that you're trying to make this work! I'm rolling my thumbs with impatience... exciting!
Mike de Boer [:mikedeboer]
Updated
[712]
*
5 years ago
Attachment #8793871 - Flags: review?(mdeboer) - feedback+
avada
Comment 24
[631]
*
4 years ago
What(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #21)
> Created attachment 8793871 [details]
> Bug 259640 - Hacky proof of concept to have Find Toolbar's highlight mode
> should show matches on top of scrollbar.
>
> Review commit: https://reviewboard.mozilla.org/r/80472/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/80472/
What's this like visually?
Jared Wein [:jaws] (please needinfo? me)
Comment 25
[f4a]
*
4 years ago
(In reply to avada from comment #24)
> What(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #21)
> > Created attachment 8793871 [details]
> > Bug 259640 - Hacky proof of concept to have Find Toolbar's highlight mode
> > should show matches on top of scrollbar.
> >
> > Review commit: https://reviewboard.mozilla.org/r/80472/diff/#index_header
> > See other reviews: https://reviewboard.mozilla.org/r/80472/
>
> What's this like visually?
This is similar to FindBar Tweak, https://addons.cdn.mozilla.net/user-media/previews/full/165/165756.png?modified=1455331568
avada
Comment 26
[631]
*
4 years ago
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #25)
> This is similar to FindBar Tweak,
> https://addons.cdn.mozilla.net/user-media/previews/full/165/165756.
> png?modified=1455331568
I'm familiar with that. I have an idea for an enhancement. The scrollbar highlits could have some transparency. That way it would show if multiple results are within a single highlight. (Which can easily happen on a long page)
YF (Yang)
Updated
[517]
*
4 years ago
Duplicate of this bug: 1335439
Mike de Boer [:mikedeboer]
Updated
[712]
*
4 years ago
Duplicate of this bug: 1352786
avada
Comment 29
[631]
*
4 years ago
Any chance of this happening, before the addon that brings this functionality stops functioning in v57?
Lucas Costi
Comment 30
[6ed]
*
4 years ago
+1 This is a pretty core feature for me. It would be a big disappointment if 57 didn't have this functionality either in the core or something that could be enabled via an addon.
Martin Strobl
Comment 31
[dab]
*
3 years ago
The "TextMarker Go" add-on (https://addons.mozilla.org/cs/firefox/addon/textmarker-go/?src=api) for Firefox Quantum has the scrollbar flag functionality, so maybe it's developer could share some knowledge on how to make the scrollbar highlight available also for the Find dialog.
Mike Conca [:mconca]
Updated
[047]
*
3 years ago
Duplicate of this bug: 1427599
Jonathan Watt [:jwatt]
Comment 33
[2e6]
*
3 years ago
Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)
Keywords: parity-chrome
Whiteboard: [Parity-Chrome] p=13 - p=13
Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]
Comment 34
[9eb]
*
2 years ago
Moving to p3 because no activity for at least 24 weeks.
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P1 - P3
Gingerbread Man
Updated
[cc5]
*
2 years ago
Duplicate of this bug: 1543382
p.bodnar
Comment 36
[1fa]
*
2 years ago
Apart from the "TextMarker Go" add-on (https://addons.mozilla.org/cs/
firefox/addon/textmarker-go/), there is also another add-on with the
same purpose: "HighlightAll" (https://addons.mozilla.org/en-US/
firefox/addon/highlightall/). One just needs to activate the "Custom
highlighting" mode in the add-on's preferences. So maybe the need to
make this a native feature diminishes, although it is possibly the
only feature which is really missed by users which come to Firefox
from Chrome - my subjective point of view though...
Matthew N. [:MattN]
Updated
[8c3]
*
2 years ago
Duplicate of this bug: 1558487
cardinleejh
Comment 38
[6f1]
*
2 years ago
(In reply to p.bodnar from comment #36)
Apart from the "TextMarker Go" add-on (https://addons.mozilla.org
/cs/firefox/addon/textmarker-go/), there is also another add-on
with the same purpose: "HighlightAll" (https://addons.mozilla.org
/en-US/firefox/addon/highlightall/). One just needs to activate
the "Custom highlighting" mode in the add-on's preferences. So
maybe the need to make this a native feature diminishes, although
it is possibly the only feature which is really missed by users
which come to Firefox from Chrome - my subjective point of view
though...
TextMarker Go is not a "highlight search results in scrollbar"
extension. It is a "display bookmarked text in scrollbar" extension.
HighlightAll does not integrate with the search functionality, and
hence does not support paging to each result.
yuweizhu90
Comment 39
[261]
*
2 years ago
advocacy
Comment hidden (advocacy)
(In reply to cardinleejh from comment #38)
(In reply to p.bodnar from comment #36)
Apart from the "TextMarker Go" add-on (https://
addons.mozilla.org/cs/firefox/addon/textmarker-go/), there is
also another add-on with the same purpose: "HighlightAll" (
https://addons.mozilla.org/en-US/firefox/addon/highlightall/
). One just needs to activate the "Custom highlighting" mode
in the add-on's preferences. So maybe the need to make this a
native feature diminishes, although it is possibly the only
feature which is really missed by users which come to Firefox
from Chrome - my subjective point of view though...
TextMarker Go is not a "highlight search results in scrollbar"
extension. It is a "display bookmarked text in scrollbar"
extension.
HighlightAll does not integrate with the search functionality,
and hence does not support paging to each result.
It really seems to me that the Firefox team does not care about this.
This issue is opened from 15 years ago and they are always busy with
something else in these 15 years. This is the feature in "find in
page" functionality that falls behind Chrome for years. They are
trying to work on Pocket, Gecko, Send, Monitor, etc. features which
only a few percent users use daily. However, they ignore this long
lasting issue in "find" feature people use everyday while pretending
this issue is resolved by plugin.
There must be something seriously wrong in the Mozilla Enterprise
culture and their management team. I guess their phylosophy might be:
be fond of the new and tired of the old.
I don't believe the Firefox team will ever implement this feature in
the page search.
Flags: needinfo?(mdeboer)
Mike de Boer [:mikedeboer]
Updated
[712]
*
2 years ago
Flags: needinfo?(mdeboer)
federico.piazza
Comment 40
[041]
*
11 months ago
I think Chrome does this since the beginning... is there any update
for this? I hate using Chrome when I need this feature.
Gingerbread Man
Updated
[cc5]
*
11 months ago
Duplicate of this bug: 1628738
Chi
Comment 42
[1ec]
*
10 months ago
Can any Mozilla developer suggest how do you jump to the correct
position quickly, without this feature, when searching on API
reference pages which usually contains dozens, if not hundreds, of
matches and screens?
My experience: on API reference pages, it is quite common that a
method name is referred dozens of times in many other methods
description, but in 98% cases, the highest density highlighted
position in scrollbar (of course, on Chrome) is the correct position
for the searched method name.
Missing this feature force me to open Chrome for just Find (on page)
feature...
lanzwjohn
Comment 43
[f7d]
*
6 months ago
I use this feature daily in my workflow.... I am currently evaluating
Firefox to determine if I can switch from Chrome (I like FF's privacy
standards) however this is surprisingly a big issue for me. I would
entertain helping to add this.
Vipul Agarwal
Comment 44
[708]
*
5 months ago
advocacy
Comment hidden (advocacy)
This is super useful feature. Please prioritize this work if
possible.
avada
Comment 45
[631]
*
3 months ago
Is there functioning workaround (addon/script/etc) for this?
The HighlightAll addon sort of is, but it's a fair bit less
comfortable to use like that.
Poopooracoocoo
Comment 46
[a22]
*
3 months ago
advocacy
Comment hidden (advocacy)
this issue is almost as old as me...
tallyo
Comment 47
[721]
*
3 months ago
advocacy
Comment hidden (advocacy)
how can this feature not be added and its requested for over a decade
long.
just what is firefox dev thinking, do they not want market share from
chrome? and to think they boast themselves to be the browser for
power users.
Poopooracoocoo
Comment 48
[a22]
*
3 months ago
advocacy
Comment hidden (advocacy)
you used to be able to add anything other browsers had to firefox,
but that was 5 years ago.
avada
Comment 49
[631]
*
3 months ago
advocacy
Comment hidden (advocacy)
(In reply to tallyo from comment #47)
how can this feature not be added and its requested for over a
decade long.
just what is firefox dev thinking, do they not want market share
from chrome? and to think they boast themselves to be the browser
for power users.
Are yo new to Firefox or Bugzilla? Everything that's not on the
trendy train takes several years to decades to infinity to implement
with the Mozilla MO. Even if they're low scale changes.
Neil Deakin
Assignee
[c9e] Comment 50
*
2 months ago
Attached file Bug 259640, add chrome only method to add scrollbar
tick marks to a window, r=smaug,tnikkel -- Details
Phabricator Automation
Updated
[a08]
*
2 months ago
Assignee: nobody - enndeakin
Status: NEW - ASSIGNED
Neil Deakin
Assignee
[c9e] Comment 51
*
2 months ago
Attached file Bug 259640, paint tick marks on vertical sliders for
the root scroll frame of the document if any have been assigned to
the window, r=tnikkel -- Details
Depends on D100938
Neil Deakin
Assignee
[c9e] Comment 52
*
2 months ago
Attached file Bug 259640, update the scroll marks when a find in page
highlight in completed, using the positions of the highlights as the
marker points, r=mikedeboer -- Details
Depends on D100939
Neil Deakin
Assignee
[c9e] Comment 53
*
2 months ago
Thought it might be fun to implement this during the break. With the
above patches, the tick marks are drawn in a window's scrollbar using
the highlight colour which defaults to something magenta-like. Note
that the 'Highlight All' toggle on the findbar needs to be on for the
tick marks to appear.
Phabricator Automation
Updated
[a08]
*
2 months ago
Attachment #9195680 - Attachment description: Bug 259640, add chrome
only method to add scrollbar tick marks to a window, r=smaug - Bug
259640, add chrome only method to add scrollbar tick marks to a
window, r=smaug,tnikkel
Neil Deakin
Assignee
[c9e] Comment 54
*
2 months ago
Attached file Bug 259640, add some reftests that verify that
scrollbar marks are drawn, r=tnikkel -- Details
Depends on D100940
Neil Deakin
Assignee
[c9e] Comment 55
*
1 month ago
Attached file Bug 259640, adjust the height of the find marks on
scrollbars based on dpi, r=tnikkel -- Details
Depends on D100940
Neil Deakin
Assignee
[c9e] Updated
*
23 days ago
Blocks: 1690128
Neil Deakin
Assignee
[c9e] Updated
*
23 days ago
Blocks: 1690129
Pulsebot
Comment 56
[4c5]
*
21 days ago
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67faf54a31a1
add chrome only method to add scrollbar tick marks to a window, r=smaug,tnikkel
https://hg.mozilla.org/integration/autoland/rev/2e218cf0cf63
paint tick marks on vertical sliders for the root scroll frame of the document if any have been assigned to the window, r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/fd4c496cee86
update the scroll marks when a find in page highlight in completed, using the positions of the highlights as the marker points, r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/3bece74bc551
adjust the height of the find marks on scrollbars based on dpi, r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/9e6cd269d773
add some reftests that verify that scrollbar marks are drawn, r=tnikkel
Dorel Luca [:dluca]
Comment 57
[059]
*
21 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/67faf54a31a1
https://hg.mozilla.org/mozilla-central/rev/2e218cf0cf63
https://hg.mozilla.org/mozilla-central/rev/fd4c496cee86
https://hg.mozilla.org/mozilla-central/rev/3bece74bc551
https://hg.mozilla.org/mozilla-central/rev/9e6cd269d773
Status: ASSIGNED - RESOLVED
Closed: 21 days ago
status-firefox87: --- - fixed
Resolution: --- - FIXED
Target Milestone: --- - 87 Branch
Mike de Boer [:mikedeboer]
Comment 58
[712]
*
20 days ago
HUGE applause to Neil for spending his spare time on this elegant
implementation of scroll marks!! I know that at least :jaws and I
have been looking at this bug with starry eyes for years and -
considering the age of this one - there must be many, many others.
Thanks so much, Neil, and keep the awesome contributions coming! ;-)
relnote-firefox: --- - ?
tustamido
Comment 59
[484]
*
20 days ago
How is this supposed to work? It's not working for me (Windows 10),
there's no marks in scrollbar after using find with some results. I
didn't notice any difference. findbar.highlightAll = true.
I asked to other Nightly users and the two answers so far was that it
isn't working for them too.
Neil Deakin
Assignee
[c9e] Comment 60
*
20 days ago
Attached file Bug 259640, fix highlightAll reference, r=mikedeboer --
Details
Neil Deakin
Assignee
[c9e] Comment 61
*
20 days ago
Bah, just put up a fix for the typo. Hopefully, this should fix
things.
Pulsebot
Comment 62
[4c5]
*
20 days ago
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d8a1ee8100c
fix highlightAll reference, r=mikedeboer
Alice0775 White
Updated
[def]
*
20 days ago
Depends on: 1690783
tustamido
Comment 63
[484]
*
20 days ago
(In reply to Neil Deakin from comment #61)
Bah, just put up a fix for the typo. Hopefully, this should fix
things.
Fixed. Tested 8d8a1ee8100c autoland build and now it's working, thank
you.
Alice0775 White
Updated
[def]
*
20 days ago
Depends on: 1690791
Andreea Pavel [:apavel]
Comment 64
[841]
*
20 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8d8a1ee8100c
Soren Hentzschel
Comment 65
[4f0]
*
19 days ago
First: Thanks for working on it! The bad news: at least on macOS the
implementation is very fragile:
Very often it doesn't highlight anything. When it works and I change
the search term the highlights do not always update. Example: I
searched for a word with many occurences, they get highlighted
correctly. Then I changed the search term to another one with only
two occurences. The number of highlights changed to two (as
expected). Then I changed the search term back to the first one again
and instead of many highlights Firefox kept the two highlight of the
previous search term.
Sometimes resizing the browser window fixed the highlights (seems to
be the opposite behaviour of bug 1690791), sometimes resizing changes
nothing.
It's also unexpected that there also highlights even with a disabled
"highlight all" feature.
I posted it here because I am not sure if these are all related
problems or if these are different bugs.
Neil Deakin
Assignee
[c9e] Comment 66
*
19 days ago
Bug 1690783 will likely fix the issues with the highlight not being
updated correctly after changing the search.
Soren Hentzschel
Comment 67
[4f0]
*
19 days ago
Thanks! I will follow bug 1690783 and file new bugs for remaining
problems (if any!) once bug 1690783 is closed. :)
Bodea Daniel [:danibodea]
Comment 68
[84c]
*
16 days ago
I can confirm that the bar with tick highlights appears when
searching existing strings in a window that has a vertical scroll
bar, but I can also reproduce the logged issues that block this bug.
Will we use this bug as a meta bug for the remaining issues/tasks? I
am thinking that we could block bug 565552 or, more likely, bug
1271782 with the remaining issues and close this current one as
verified. What do you think?
Flags: needinfo?(mdeboer)
Flags: needinfo?(enndeakin)
Blake Winton (:bwinton) (:[?][?])
Updated
[a4f]
*
14 days ago
Depends on: 1691978
masih
Comment 69
[734]
*
5 days ago
Hi this feature doesn't work on pdf files.
Mike de Boer [:mikedeboer]
Updated
[712]
*
4 days ago
Depends on: 1693784
Calixte Denizet (:calixte)
Updated
[1c2]
*
4 days ago
Depends on: 1694027
You need to log in before you can comment on or make changes to this
bug.
Top |