igettextprop: check result of XGetTextProperty (undefined behaviour for XFree) - dwm - dynamic window manager Err parazyd.org 70 hgit clone https://git.parazyd.org/dwm URL:https://git.parazyd.org/dwm parazyd.org 70 1Log /git/dwm/log.gph parazyd.org 70 1Files /git/dwm/files.gph parazyd.org 70 1Refs /git/dwm/refs.gph parazyd.org 70 1README /git/dwm/file/README.gph parazyd.org 70 1LICENSE /git/dwm/file/LICENSE.gph parazyd.org 70 i--- Err parazyd.org 70 1commit 99f78fa553f9ddb23fab73e47a408d66ca7f974c /git/dwm/commit/99f78fa553f9ddb23fab73e47a408d66ca7f974c.gph parazyd.org 70 1parent a9b6a312a77b9cc81ca8b08a95c09e9f7948d7a6 /git/dwm/commit/a9b6a312a77b9cc81ca8b08a95c09e9f7948d7a6.gph parazyd.org 70 hAuthor: Hiltjo Posthuma URL:mailto:hiltjo@codemadness.org parazyd.org 70 iDate: Fri, 3 Nov 2017 16:36:32 +0100 Err parazyd.org 70 i Err parazyd.org 70 igettextprop: check result of XGetTextProperty (undefined behaviour for XFree) Err parazyd.org 70 i Err parazyd.org 70 iDiffstat: Err parazyd.org 70 i M dwm.c | 3 +-- Err parazyd.org 70 i Err parazyd.org 70 i1 file changed, 1 insertion(+), 2 deletions(-) Err parazyd.org 70 i--- Err parazyd.org 70 1diff --git a/dwm.c b/dwm.c /git/dwm/file/dwm.c.gph parazyd.org 70 i@@ -910,8 +910,7 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size) Err parazyd.org 70 i if (!text || size == 0) Err parazyd.org 70 i return 0; Err parazyd.org 70 i text[0] = '\0'; Err parazyd.org 70 i- XGetTextProperty(dpy, w, &name, atom); Err parazyd.org 70 i- if (!name.nitems) Err parazyd.org 70 i+ if (!XGetTextProperty(dpy, w, &name, atom) || !name.nitems) Err parazyd.org 70 i return 0; Err parazyd.org 70 i if (name.encoding == XA_STRING) Err parazyd.org 70 i strncpy(text, (char *)name.value, size - 1); Err parazyd.org 70 .