itpopen: remove close-on-exec flag to increase portability a bit - sacc - sacc(omys), simple console gopher client (mirror) Err parazyd.org 70 hgit clone https://git.parazyd.org/sacc URL:https://git.parazyd.org/sacc parazyd.org 70 1Log /git/sacc/log.gph parazyd.org 70 1Files /git/sacc/files.gph parazyd.org 70 1Refs /git/sacc/refs.gph parazyd.org 70 1LICENSE /git/sacc/file/LICENSE.gph parazyd.org 70 i--- Err parazyd.org 70 1commit f1432f5a5c56bad44485d9dee8fe92e6d09e1f4c /git/sacc/commit/f1432f5a5c56bad44485d9dee8fe92e6d09e1f4c.gph parazyd.org 70 1parent 62d746cb6d34ed43068386bcd4a75f828055ee5e /git/sacc/commit/62d746cb6d34ed43068386bcd4a75f828055ee5e.gph parazyd.org 70 hAuthor: Hiltjo Posthuma URL:mailto:hiltjo@codemadness.org parazyd.org 70 iDate: Thu, 2 Jul 2020 23:26:09 +0200 Err parazyd.org 70 i Err parazyd.org 70 ipopen: remove close-on-exec flag to increase portability a bit Err parazyd.org 70 i Err parazyd.org 70 iPOSIX says: Err parazyd.org 70 i"If mode is any other value, the result is unspecified.". Err parazyd.org 70 i Err parazyd.org 70 iOn atleast older glibc versions (afaik 2008 and older) and on current HaikuOS Err parazyd.org 70 iit seems to not execute popen when "e" is set and set errno to EINVAL. Err parazyd.org 70 i Err parazyd.org 70 iDiffstat: Err parazyd.org 70 i M sacc.c | 2 +- Err parazyd.org 70 i Err parazyd.org 70 i1 file changed, 1 insertion(+), 1 deletion(-) Err parazyd.org 70 i--- Err parazyd.org 70 1diff --git a/sacc.c b/sacc.c /git/sacc/file/sacc.c.gph parazyd.org 70 it@@ -285,7 +285,7 @@ displaytextitem(Item *item) Err parazyd.org 70 i return; Err parazyd.org 70 i case 0: Err parazyd.org 70 i parent = 0; Err parazyd.org 70 i- if (!(pagerin = popen("$PAGER", "we"))) Err parazyd.org 70 i+ if (!(pagerin = popen("$PAGER", "w"))) Err parazyd.org 70 i _exit(1); Err parazyd.org 70 i fputs(item->raw, pagerin); Err parazyd.org 70 i exit(pclose(pagerin)); Err parazyd.org 70 .